Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: init release-8.5 configs #19545

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Dec 2, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Remove all aliases
  • Delete the TiDB roadmap file
  • Update the link of the roadmap in TOC
  • Update the links in the index page to v8.5
  • Update GitHub code links from master to release-8.5
  • Update the dev links to v8.5 links for dev docs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch
    …ap and support policy

@qiancai qiancai added area/develop This PR relates to the area of TiDB App development. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 2, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 2, 2024

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot bot requested a review from Oreoxmt December 2, 2024 08:39
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 2, 2024

Should we update the version reference from "dev" to "v8.5" in the following lines?

<td rowspan="4">Python</td>
<td>TiDB Vector Client</td>
<td><code>pip install tidb-vector[client]</code></td>
<td><a href="/tidb/dev/vector-search-get-started-using-python">Get Started with Vector Search Using Python</a></td>
</tr>
<tr>
<td>SQLAlchemy</td>
<td><code>pip install tidb-vector</code></td>
<td><a href="/tidb/dev/vector-search-integrate-with-sqlalchemy">Integrate TiDB Vector Search with SQLAlchemy</a></td>
</tr>
<tr>
<td>peewee</td>
<td><code>pip install tidb-vector</code></td>
<td><a href="/tidb/dev/vector-search-integrate-with-peewee">Integrate TiDB Vector Search with peewee</a></td>
</tr>
<tr>
<td>Django</td>
<td><code>pip install django-tidb[vector]</code></td>
<td><a href="/tidb/dev/vector-search-integrate-with-django-orm">Integrate TiDB Vector Search with Django</a></td>

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 2, 2024

The version updates of GitHub links in docs-cn (pingcap/docs-cn@7250cf2) haven't been synchronized with the English docs.

@qiancai
Copy link
Collaborator Author

qiancai commented Dec 3, 2024

The version updates of GitHub links in docs-cn (pingcap/docs-cn@7250cf2) haven't been synchronized with the English docs.

Done in 215a2a5 (#19545).

@qiancai
Copy link
Collaborator Author

qiancai commented Dec 3, 2024

Should we update the version reference from "dev" to "v8.5" in the following lines?

<td rowspan="4">Python</td>
<td>TiDB Vector Client</td>
<td><code>pip install tidb-vector[client]</code></td>
<td><a href="/tidb/dev/vector-search-get-started-using-python">Get Started with Vector Search Using Python</a></td>
</tr>
<tr>
<td>SQLAlchemy</td>
<td><code>pip install tidb-vector</code></td>
<td><a href="/tidb/dev/vector-search-integrate-with-sqlalchemy">Integrate TiDB Vector Search with SQLAlchemy</a></td>
</tr>
<tr>
<td>peewee</td>
<td><code>pip install tidb-vector</code></td>
<td><a href="/tidb/dev/vector-search-integrate-with-peewee">Integrate TiDB Vector Search with peewee</a></td>
</tr>
<tr>
<td>Django</td>
<td><code>pip install django-tidb[vector]</code></td>
<td><a href="/tidb/dev/vector-search-integrate-with-django-orm">Integrate TiDB Vector Search with Django</a></td>

Yes, thanks for the catch. Done in 9c5e0e5 (#19545).

Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 3, 2024
Copy link

ti-chi-bot bot commented Dec 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-03 10:23:26.48057884 +0000 UTC m=+1150394.100233356: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Collaborator Author

qiancai commented Dec 4, 2024

/approve

@qiancai qiancai added the lgtm label Dec 4, 2024
Copy link

ti-chi-bot bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit b12adef into pingcap:release-8.5 Dec 4, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants