Updated signing process #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json
src/auth/index.ts
Outdated
| case "cached": | ||
| return new CachedSigner(options.secretKey, options.expirationTime); | ||
| case "payload": | ||
| return new PayloadSigner(options.secretKey); |
There was a problem hiding this comment.
Oh let's not provide both options
Either or, not both
This makes the documentation really confusing because then we need to explain both
src/auth/payload-signer.ts
Outdated
| import nacl from "tweetnacl"; | ||
| import { Signer } from "./index.js"; | ||
|
|
||
| export class PayloadSigner implements Signer { |
There was a problem hiding this comment.
This doesn't need to be a class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to sign a temporary token and cache it for an predefined amount of time. This allows every connected sink to reduce the required work to validate signatures because the received signature will be already known.
This feature is turned off by default. It can be turned on by setting--signature cachedwhen launching the sink.The signature expiry time can be controlled via
--expiry-time <number>The caching offers these performance on my machine: