Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement LimitConsoleLength console reader option #3

Open
fschoell opened this issue Sep 30, 2022 · 3 comments
Open

Reimplement LimitConsoleLength console reader option #3

fschoell opened this issue Sep 30, 2022 · 3 comments
Assignees

Comments

@fschoell
Copy link
Contributor

No description provided.

@fschoell fschoell self-assigned this Sep 30, 2022
@matthewdarwin
Copy link

We need to think about this one. Anything that causes blocks to be different between firehose providers is really not desirable in the graph ecosystem. We want the blocks to be provably the same everywhere.

@fschoell
Copy link
Contributor Author

this is just a reminder I've added, because the console reader options that were used to implement limiting the console length were removed in the upstream code. I don't think this option was used on dfuse before and we can decide not to reimplement it, not sure what it was used for in the first place.

@matthewdarwin
Copy link

I think the option was there because in Antelope chains you can write tons of console output which is not billed for. So denial of service possibility. When we were doing initial testing, I limited the console output during some tests. The option was added for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants