Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ikhal: Unreadable colors for agenda selection in new event #1353

Open
pdav opened this issue May 30, 2024 · 2 comments
Open

ikhal: Unreadable colors for agenda selection in new event #1353

pdav opened this issue May 30, 2024 · 2 comments

Comments

@pdav
Copy link
Contributor

pdav commented May 30, 2024

Describe the bug
With the light color theme, agenda selection is done with a black background which makes agenda names unreadable (see attached picture)

If applicable: Stack Trace
N/A

To Reproduce
Steps to reproduce the behavior:

[calendars]
  [[pda]]
    path = ...
    color = dark blue

....
[view]
  theme = light

Expected behavior
Agenda selection menu should use a light background for names.

Screenshots
colors

OS, version, khal version and how you installed it:

  • The output of khal --version: khal, version 0.11.3.dev206+g4b6e7991
  • Installation method: git
  • python version: Python 3.12.3 (main, Apr 10 2024, 05:33:47) [GCC 13.2.0] on linux
  • OS: Linux vagabond 6.8.0-31-generic 31-Ubuntu SMP PREEMPT_DYNAMIC Sat Apr 20 00:40:06 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
  • Your khal config file: see above
  • The versions of your other python packages [e.g. the output of pip freeze]:
atomicwrites==1.4.1
click==8.1.7
click-log==0.4.0
configobj==5.0.8
icalendar==5.0.12
-e git+ssh://[email protected]/pdav/khal.git@4b6e79912eca9c3fcba8415d4e0c18d87e9d13f4#egg=khal
python-dateutil==2.9.0.post0
pytz==2024.1
pyxdg==0.28
six==1.16.0
typing_extensions==4.11.0
tzlocal==5.2
urwid==2.6.12
wcwidth==0.2.13

Additional context
N/A

@d7415 d7415 changed the title Unreadable colors for agenda selection in new event ikhal: Unreadable colors for agenda selection in new event May 30, 2024
@marcEml
Copy link

marcEml commented Nov 6, 2024

Hi, I'm a junior developer and I'd like to work on this issue if no one has already taken it on.

@WhyNotHugo
Copy link
Member

@marcEml Set up khal locally and make sure you can reproduce the issue first.

After that, try and find where this colour is hardcoded in the codebase. There's likely a black or #000000 somewhere. It needs to change depending on the colour scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants