Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[510] Create Select Component #581

Merged
merged 33 commits into from
Oct 14, 2024
Merged

[510] Create Select Component #581

merged 33 commits into from
Oct 14, 2024

Conversation

ValeriaMaltseva
Copy link
Contributor

Task: #510

@ValeriaMaltseva
refactored the customMetadata container
ae8d906
@ValeriaMaltseva
added the Select component
1da7caf
@ValeriaMaltseva
updated components using a custom select
4ee1afd
@ValeriaMaltseva
updated components using a custom select
ebbf409
@ValeriaMaltseva
updated components using a custom select
d25f30b
@ValeriaMaltseva
refactored the component
96066f5
@ValeriaMaltseva
updated components using a custom select
9edb7f1
@ValeriaMaltseva
updated component
4cce646
@ValeriaMaltseva
merged changes from the main branch
47f505e
@ValeriaMaltseva
updated the Select component: added customArrowIcon prop
61a8bca
@ValeriaMaltseva
updated styles for the component
c4a9aa6
@ValeriaMaltseva
added style for warning and error states
3ff0311
@ValeriaMaltseva
added styles for multiple select
f5b78b0
@ValeriaMaltseva
updated the Select component
ec8db5c
@ValeriaMaltseva
updated styles
19dc816
@ValeriaMaltseva
added withCustomIcon props into the Select component
17ecf9e
@ValeriaMaltseva
updated component: change component to custom one
a6db41c
@ValeriaMaltseva
updated component: change component to custom one
2d23cf4
@ValeriaMaltseva
updated component
20bb37d
@ValeriaMaltseva ValeriaMaltseva changed the title [DRAFT] [510] Create Select Component [510] Create Select Component Oct 11, 2024
vin0401
vin0401 requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@vin0401 vin0401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already pretty good to me. But still, there are a few smaller improvements I would love to see, if possible.

assets/js/src/core/components/select/select.styles.ts Show resolved Hide resolved
...e/modules/asset/editor/shared-tab-manager/tabs/custom-metadata/custom-metadata-container.tsx Outdated Show resolved Hide resolved
...es/asset/editor/types/image/tab-manager/tabs/preview/sidebar/tabs/details/helpers/config.tsx Outdated Show resolved Hide resolved
...re/modules/element/editor/shared-tab-manager/tabs/properties/properties-container.styles.tsx Outdated Show resolved Hide resolved
@ValeriaMaltseva ValeriaMaltseva merged commit 45803e0 into 1.x Oct 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
@ValeriaMaltseva ValeriaMaltseva deleted the 510-create-select-component branch October 14, 2024 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vin0401 vin0401 vin0401 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValeriaMaltseva @vin0401