-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Asset exists check for files within folders when drag and dropping. #725
Open
cancan101
wants to merge
4
commits into
pimcore:1.6
Choose a base branch
from
cancan101:fix/folderdnd-exists
base: 1.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancan101
changed the title
Fix Asset exists check for files within folders when drag and droppping.
Fix Asset exists check for files within folders when drag and dropping.
Oct 17, 2024
mattamon
reviewed
Nov 8, 2024
any other comments on the PR? |
Hey @cancan101, |
cancan101
force-pushed
the
fix/folderdnd-exists
branch
from
November 19, 2024 16:10
38e3aa5
to
c4b2cc2
Compare
cancan101
force-pushed
the
fix/folderdnd-exists
branch
from
November 19, 2024 16:11
c4b2cc2
to
ce9ba2a
Compare
done |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #626
The asset is not correctly resolved in the exists check if it is in a folder.
Currently, the
add-asset
endpoint is passed the directory path but theexists
endpoint is not.