Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Delete and Edit of Objects from Grid View Based on Workflow and User Permissions #673

Open
cancan101 opened this issue Aug 29, 2024 · 1 comment

Comments

@cancan101
Copy link
Contributor

cancan101 commented Aug 29, 2024

These actions in the Grid View should all be controlled based on both the workflow and user permissions:

  1. (Bulk) editing of Objects
  2. Single deleting of Objects
  3. Bulk deleting of Objects

(2) is partially addressed in #671. It currently checks user permission, but not workflow permission
(3) was attempted in #530

CC @kingjia90 @mattamon

For the individual elements, this code runs

$data['userPermissions'] = array_merge(
isset($data['userPermissions']) ? (array)$data['userPermissions'] : [],
$placeConfig->getUserPermissions($workflow, $element)
);

and set the permissions on the userPermissions payload which is used by isAllowed.

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant