Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate function name #11

Open
johanneskoch94 opened this issue Feb 14, 2023 · 0 comments
Open

Duplicate function name #11

johanneskoch94 opened this issue Feb 14, 2023 · 0 comments

Comments

@johanneskoch94
Copy link
Member

This function

calcValidPopulation <- function(PopulationPast = "WDI-UN_PopDiv-MI",
PopulationFuture = c("SSPs-UN_PopDiv-MI",
"SDPs-UN_PopDiv-MI",
"SSP2EU-UN_PopDiv-MI"),
TimeFromFindSet = TRUE) {

is redefined here, with the same name:
https://github.com/pik-piam/mrtutorial/blob/552a5a1936274145159065db4b9d3485758f8d78/R/calcValidPopulation.R#L9

This could cause issues down the line I'ld guess ;) In any case, the calcValidPopulation function from this package looks dubious to me. It uses future data for validation, but takes it from calcPopulationFuture, instead of from calcPopulation which has the final scenario data after harmonization. So depending on which function is actually used in our workflows, this should be either refactored (I can do that), or deleted.

I'm not sure who has a good overview ;) @caviddhen @tscheypidi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant