You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This could cause issues down the line I'ld guess ;) In any case, the calcValidPopulation function from this package looks dubious to me. It uses future data for validation, but takes it from calcPopulationFuture, instead of from calcPopulation which has the final scenario data after harmonization. So depending on which function is actually used in our workflows, this should be either refactored (I can do that), or deleted.
This function
mrvalidation/R/calcValidPopulation.R
Lines 13 to 17 in 9b6ae61
is redefined here, with the same name:
https://github.com/pik-piam/mrtutorial/blob/552a5a1936274145159065db4b9d3485758f8d78/R/calcValidPopulation.R#L9
This could cause issues down the line I'ld guess ;) In any case, the calcValidPopulation function from this package looks dubious to me. It uses future data for validation, but takes it from calcPopulationFuture, instead of from calcPopulation which has the final scenario data after harmonization. So depending on which function is actually used in our workflows, this should be either refactored (I can do that), or deleted.
I'm not sure who has a good overview ;) @caviddhen @tscheypidi
The text was updated successfully, but these errors were encountered: