Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: UI border of cards on dashboards #839

Closed
ryanevans-dev opened this issue Nov 9, 2022 · 12 comments
Closed

Bug: UI border of cards on dashboards #839

ryanevans-dev opened this issue Nov 9, 2022 · 12 comments
Labels
bug Something isn't working

Comments

@ryanevans-dev
Copy link

Current Behavior

There is now an border around cards on the new HA UI, for example on the chip card there is an border which group them all, this was previously not the case.

Expected Behavior

For the border to be invisible or not present at all.

I suspect this is HA updates themselves causing this border rather than this integration, but can it be overridden?

Steps To Reproduce

Go onto HA dashboard
Add chip card (plus others)
You will see a faint border across the screen.

Context

No response

Environment

- Browser: Mobile App
- HA Version: 2022.11.2
- Mushroom: 2.1.3

Anything else?

No response

@ryanevans-dev ryanevans-dev added the bug Something isn't working label Nov 9, 2022
@piitaya
Copy link
Owner

piitaya commented Nov 9, 2022

Duplicate of #822 #813 #795 and already fixed. You need to update to the latest mushroom version.

@piitaya piitaya closed this as completed Nov 9, 2022
@chench00
Copy link

@piitaya I am running v2.4.1 and still see the borders:

Screen Shot 2022-11-25 at 11 52 18 AM

Do I need to add any extra code?

@piitaya
Copy link
Owner

piitaya commented Nov 25, 2022

Do you have this in your console ?
CleanShot 2022-11-25 at 17 55 11

@chench00
Copy link

I see this in HACS:

Screen Shot 2022-11-25 at 11 57 33 AM

@piitaya
Copy link
Owner

piitaya commented Nov 25, 2022

Look into your browser console. I think you have a cache issue 🙂

@chench00
Copy link

Screen Shot 2022-11-25 at 12 00 49 PM

@piitaya
Copy link
Owner

piitaya commented Nov 25, 2022

Oh wait, is it in a stack-in-card card ? Stack in card is not fixed with the new border for cards : custom-cards/stack-in-card#47

@chench00
Copy link

I actually downloaded the updated .js card and uploaded into my configuration and the borders are gone but not around the chips.

@piitaya
Copy link
Owner

piitaya commented Nov 25, 2022

How did you do to remove the box shadow with the old version ? Can you share the yaml of your card?

@chench00
Copy link

chench00 commented Nov 25, 2022

I only uploaded the .js fine and the border disappeared. I didn't have to change anything.

@chench00
Copy link

chench00 commented Nov 27, 2022

@piitaya Any other suggestions?

Example:

    type: custom:layout-card
    layout_type: custom:grid-layout
    cards:
      - views:
          - title: Home
        type: custom:stack-in-card
        mode: vertical
        cards:
          - type: custom:mushroom-title-card
            title: Hallway
          - type: custom:stack-in-card
            mode: horizontal
            cards:
              - type: custom:mushroom-template-card
                icon: mdi:light-switch
                layout: vertical
                tap_action:
                  action: toggle
                hold_action:
                  action: none
                double_tap_action:
                  action: none
                entity: switch.hallway
                icon_color: |-
                  {% set state=states('switch.hallway') %}
                  {% if state=='on' %}
                  orange
                  {% elif state=='off' %}
                  white
                  {% endif %}
                secondary: '{{ states(''switch.hallway'')}}'
                multiline_secondary: true
                primary: Hallway
    layout:
      height: 225px

Screen Shot 2022-11-26 at 6 13 06 PM

@piitaya
Copy link
Owner

piitaya commented Nov 27, 2022

I don't use stack in card so I can not help with that 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants