Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to present 'side of road' when editing left/right sides? #680

Open
riQQ opened this issue Feb 26, 2022 · 5 comments
Open

How to present 'side of road' when editing left/right sides? #680

riQQ opened this issue Feb 26, 2022 · 5 comments
Labels
enhancement New feature or request low-priority Might be fixed one day... or not UI Related to the user interface

Comments

@riQQ
Copy link
Collaborator

riQQ commented Feb 26, 2022

The image of the selected element covers the question form.

Example location:
https://mapcomplete.osm.be/sidewalks.html?z=18&lat=52.52663&lon=13.46859&language=en#way/197740392

image on top of question form

@riQQ riQQ added bug Something isn't working UI Related to the user interface labels Feb 26, 2022
@pietervdvn
Copy link
Owner

Hi,

This is a bit a tricky useability question: it has to be clear that one is answering questions about one side of the road; hence the pretty prominent minimap.

(The "loopings" are due to an upstream bug in polyline-offset)

@pietervdvn pietervdvn added the low-priority Might be fixed one day... or not label Feb 27, 2022
@riQQ
Copy link
Collaborator Author

riQQ commented Feb 27, 2022

(The "loopings" are due to an upstream bug in polyline-offset)

This is bbecquet/Leaflet.PolylineOffset#1, right?

@pietervdvn
Copy link
Owner

(The "loopings" are due to an upstream bug in polyline-offset)

This is bbecquet/Leaflet.PolylineOffset#1, right?

Yes.

By the way, in your original screenshot, scrolling up should improve the layout.

@riQQ riQQ changed the title Image covers question form Image covers question form when scrolling Mar 1, 2022
@riQQ
Copy link
Collaborator Author

riQQ commented Mar 1, 2022

By the way, in your original screenshot, scrolling up should improve the layout.

I know, maybe I wasn't clear but this issue is exactly about the scrolling behaviour.

@pietervdvn
Copy link
Owner

Ah, good.

Well, in either case, the sidewalks-theme is more or less an experiment and showcase. The UI/UX for this isn't good (which is also why this is a hidden theme).

Do you have a proposal on how to improve it?

Keep in mind that:

  • it is for now technically impossible to indicate wether the "left" or "right" side of the road has been selected, so all questions/information has to go into the same popup
  • from a UI-perspective, I also don't think that letting ppl click the 'left' or 'right' side of the road is a good idea. Misclicks happen, especially on mobile.
  • It is impossible to use 'left' and 'right' as terms when presenting this to the user. A road which is drawn from north to south will have the left side on the right side of the screen from a users perspective! (Not mentioning that a surprisingly big group of persons switch left and right)

So, I wanted to always have the minimap on top showing precisely which side of the road they are editing, also when scrolling. This is implemented using the 'sticky attribute', which might scroll over subparts. This doesn't work very well in practice though, but I don't immediately see a better way.

@pietervdvn pietervdvn added enhancement New feature or request and removed bug Something isn't working labels Mar 1, 2022
@pietervdvn pietervdvn changed the title Image covers question form when scrolling How to present 'side of road' when editing left/right sides? Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority Might be fixed one day... or not UI Related to the user interface
Projects
None yet
Development

No branches or pull requests

2 participants