You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ran into a bug (I think) with ReactOverlayView. Here's what I think is happening:
MyReactComponent renders a Map component with overlays.
Before the Google Maps JS can add the overlays to the Google Map, MyReactComponent#setState triggers a re-render (because of Flux in my case).
React calls ReactOverlayView#componentDidUpdate, which calls MapOverlayView#draw. (Note that MapOverlayView#add has still not been called.)
MapOverlayView#getProjection returns undefined, so the following error appears: Uncaught TypeError: Cannot read property 'fromLatLngToDivPixel' of undefined
I think the fix is pretty simple -- have ReactOverlayView#componentDidUpdate check whether __node has a _containerElement before drawing (which means that onAdd has been called and drawing is 👍 ).
Pull request incoming, but feel free to push back if there's a better solution.
The text was updated successfully, but these errors were encountered:
I ran into a bug (I think) with ReactOverlayView. Here's what I think is happening:
MyReactComponent#setState
triggers a re-render (because of Flux in my case).ReactOverlayView#componentDidUpdate
, which callsMapOverlayView#draw
. (Note thatMapOverlayView#add
has still not been called.)MapOverlayView#getProjection
returns undefined, so the following error appears:Uncaught TypeError: Cannot read property 'fromLatLngToDivPixel' of undefined
I think the fix is pretty simple -- have
ReactOverlayView#componentDidUpdate
check whether__node
has a_containerElement
before drawing (which means that onAdd has been called and drawing is 👍 ).Pull request incoming, but feel free to push back if there's a better solution.
The text was updated successfully, but these errors were encountered: