Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lex file duplication #127

Open
SamuelmsWong-zz opened this issue Oct 16, 2019 · 3 comments
Open

Remove lex file duplication #127

SamuelmsWong-zz opened this issue Oct 16, 2019 · 3 comments
Labels
Help Wanted

Comments

@SamuelmsWong-zz
Copy link
Contributor

lex-hitachi-sh.c and lex-riscv.c differ only in the tokens for their assembly instructions, so the rest (tokens for Sunflower commands and the lexical analyser function) is all duplicated.
Open
phillipstanleymarbell referenced this issue Nov 30, 2019
@jan-heck
Tried to find issue with run.m
5b3aec7 
Using `setnode 1` does not appear to change anything. Even `version` is
not shown. This issue is put aside for later.
Open
@phillipstanleymarbell phillipstanleymarbell added Help Wanted Next-Up Next up for implementation labels Nov 30, 2019
@phillipstanleymarbell
Copy link
Member

One approach would be to split off the common %token T_* at the start of the .ys into a sf-common-tokens.y and to similarly split off the common grammar rules into a sf-common-grammar.y. @samuelmswong @rjlv2 @jan-heck : if any of you are interested...

Open
@phillipstanleymarbell phillipstanleymarbell removed the Next-Up Next up for implementation label Dec 1, 2019
@SamuelmsWong-zz
Copy link
Contributor Author

Hi. I can probably get started on this in a few weeks.

@phillipstanleymarbell
Copy link
Member

That's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillipstanleymarbell @SamuelmsWong-zz