Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CDAO:has_Ancestor expression with phyloref:has_outside_TU #83

Open
gaurav opened this issue Mar 8, 2021 · 1 comment
Open

Comments

@gaurav
Copy link
Member

gaurav commented Mar 8, 2021

The upcoming release of the Phyloref Ontology will have a phyloref:has_outside_TU property that is equivalent to has_Ancestor o excludes_TU. We can therefore replace the expanded version of this expression in PhylorefWrapper.js with this new term once the new version of the Phyloref Ontology has been released.

remainingExternals.forEach((externalTU) => {
intersectionExprs.push({
'@type': 'owl:Restriction',
onProperty: 'obo:CDAO_0000144', // has_Ancestor
someValuesFrom: {
'@type': 'owl:Restriction',
onProperty: 'phyloref:excludes_TU',
someValuesFrom: new TaxonomicUnitWrapper(
externalTU,
this.defaultNomenCode
).asOWLEquivClass,
},
});
});

@gaurav
Copy link
Member Author

gaurav commented May 24, 2023

We still use obo:CDAO_0000144, so we probably should consider whether we should replace it with phyloref:has_outside_TU, especially if that helps with removing redundant classes (#90).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant