Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate nameString in favor of hasName names with nomenclatural codes #40

Open
gaurav opened this issue Sep 16, 2019 · 1 comment
Open

Deprecate nameString in favor of hasName names with nomenclatural codes #40

gaurav opened this issue Sep 16, 2019 · 1 comment

Comments

@gaurav
Copy link
Member

gaurav commented Sep 16, 2019

Now that we've implemented #20, we sometimes run into an issue where an entry has both a hasName as well as a nameString. Since nameString doesn't include a nomenclatural code, it might be worth deprecating nameString entirely and insisting that everybody uses hasName.
@hlapp
Copy link
Member

hlapp commented Sep 17, 2019

There is no reason not to have a canonical representation for a standard exchange format, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaurav @hlapp