Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for normalization #141

Open
gaurav opened this issue Jun 18, 2024 · 0 comments
Open

Improve tests for normalization #141

gaurav opened this issue Jun 18, 2024 · 0 comments

Comments

@gaurav
Copy link
Member

gaurav commented Jun 18, 2024

Most normalization methods start by deep cloning the object being normalized -- this means that if we were to add new properties to those methods, they would be included in the normalized object:

Some of them, however, specifically pick the properties/keys needed to construct normalized versions of taxon concepts, taxon name and specimen:

To comprehensively test normalization going forward, we should test:

  1. Whether an unknown property in the first group of normalization methods is correctly transferred into the normalized object.
  2. Whether an unknown property in the second group of normalization methods is correctly NOT transferred into the normalized object.
  3. (Not currently implemented) Whether an unknown property in the second group correctly produces some kind of warning object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant