-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Testudinata from phylonym as an example of an apomorphy-based phyloref #291
Conversation
6678b74
to
9e60b56
Compare
|
Here's where I am with the interface right now (as of a1d9cdd). I moved all the specifier groups into cards, which makes it easier to add elements to the header. Adding a check box immediately to the right of the "Apomorphy" looked odd, but then I could realize I could add a button to float right in all three card headers -- for "Internal specifiers" and "External specifiers", this button would add a new specifier to the list, and for "Apomorphy" it would toggle whether any apomorphy was present. So, if there is no apomorphy, the specifier card looks like this: But if you then click on the check box beside the "Apomorphy", the apomorphy check box is selected and the apomorphy details appear: I'm looking through the Bootstrap icons to see if I can find one that more clearly indicates "This is a checkbox". If I can't find one, I'm planning to change the text in the apomorphy to read:
Where clicking on "Set one?" would select the checkbox and display the apomorphy details. What do y'all think? |
I think that's reasonable. As we discussed, I wouldn't spent too much time on over optimizing the UI. |
This is because of keesey/newick-js#4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good. I notice that there are repeated instanced of id=bearing-entity
in the VUE code, but perhaps I'm just not understanding VUE well enough. So I'll tentatively approve.
This PR adds support for entering apomorphy-based clade definitions in Klados. Note that the Testudinata citation isn't working because of #301 -- I think we can review this PR without fixing that. The remaining functionality appears to be working.
Initially the Phyloref interface looks like this:
Clicking on the box in the top right of the "Apomorphy" box causes the description to open:
This PR includes an apomorphy-based definition from Phylonym:
I've also modified the summary page to indicate that we don't expect apomorphy-based phylorefs to resolve: