Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Testudinata from phylonym as an example of an apomorphy-based phyloref #291

Merged
merged 16 commits into from
Jul 5, 2023

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Mar 8, 2023

This PR adds support for entering apomorphy-based clade definitions in Klados. Note that the Testudinata citation isn't working because of #301 -- I think we can review this PR without fixing that. The remaining functionality appears to be working.

Initially the Phyloref interface looks like this:
Screenshot 2023-06-21 at 3 14 44 AM

Clicking on the box in the top right of the "Apomorphy" box causes the description to open:
Screenshot 2023-06-21 at 3 02 10 AM

This PR includes an apomorphy-based definition from Phylonym:
Screenshot 2023-06-21 at 3 16 25 AM

I've also modified the summary page to indicate that we don't expect apomorphy-based phylorefs to resolve:
Screenshot 2023-06-21 at 3 01 15 AM

@gaurav
Copy link
Member Author

gaurav commented Mar 29, 2023

  • Add a checkbox after the word "Apomorphy" in the title
  • Leaning towards removing the "Bearing entity" and "Phenotypic quality" fields -- for this version, just the free text definition is probably sufficient. Moved to Improve the apomorphy description in apomorphy-based phylorefs #302
  • Explicitly include PATO and UBERON terms in the free text example so that users know that they can include term URIs or Manchester syntax in the freetext definition if necessary.

In the future, we might want a "related entity" field as well. Gaurav to talk to Jim about this. Maybe a Manchester syntax field? Moved to #302

@gaurav
Copy link
Member Author

gaurav commented Apr 26, 2023

Here's where I am with the interface right now (as of a1d9cdd). I moved all the specifier groups into cards, which makes it easier to add elements to the header. Adding a check box immediately to the right of the "Apomorphy" looked odd, but then I could realize I could add a button to float right in all three card headers -- for "Internal specifiers" and "External specifiers", this button would add a new specifier to the list, and for "Apomorphy" it would toggle whether any apomorphy was present. So, if there is no apomorphy, the specifier card looks like this:

Screenshot 2023-04-26 at 1 47 01 AM

But if you then click on the check box beside the "Apomorphy", the apomorphy check box is selected and the apomorphy details appear:

Screenshot 2023-04-26 at 1 46 33 AM

I'm looking through the Bootstrap icons to see if I can find one that more clearly indicates "This is a checkbox". If I can't find one, I'm planning to change the text in the apomorphy to read:

No apomorphy in this phyloreference. Set one?

Where clicking on "Set one?" would select the checkbox and display the apomorphy details.

What do y'all think?

@hlapp
Copy link
Member

hlapp commented Apr 26, 2023

I think that's reasonable. As we discussed, I wouldn't spent too much time on over optimizing the UI.

@gaurav gaurav changed the title Add Testudinata from phylonym as an example of a apomorphy-based phyloref Add Testudinata from phylonym as an example of an apomorphy-based phyloref May 7, 2023
@gaurav gaurav marked this pull request as ready for review June 21, 2023 07:24
@gaurav gaurav requested a review from hlapp June 21, 2023 07:24
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good. I notice that there are repeated instanced of id=bearing-entity in the VUE code, but perhaps I'm just not understanding VUE well enough. So I'll tentatively approve.

@gaurav
Copy link
Member Author

gaurav commented Jul 5, 2023

@hlapp Good catch -- I did have some misnamed ids! They don't matter for rendering, but I've fixed them in 1ac9ec1.

@gaurav gaurav merged commit b677e98 into master Jul 5, 2023
@gaurav gaurav deleted the add-apomorphy-phyloref branch July 5, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants