-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional example file: Fisher et al, 2007 #278
Conversation
Aha, I've figured out what the problem is with Fisher et al, 2007: the phylogeny nodes aren't being notated with any nomenclatural code. This is because phyx.js uses the following logic to determine how to choose a nomenclatural code: I should be able to use |
This will set phylogeny nodes to a nomenclatural code of ICBN.
The main thing this file demonstrates is including genetic information in the taxon concepts or annotating them on phylogenies, but none of that is really an important Klados use-case.
But we've been using defaultNomenclaturalCodeURI in Klados.
I'll implement that in a separate issue and PR.
d2c4b66
to
26a239f
Compare
Moving content from the PR description into an issue so we document some fixes: Outstanding issues with Fisher et al:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…laturalCodeURI I fixed some references to defaultNomenclaturalCodeURI as part of PR #278, but I also missed others. This PR replaces those with `defaultNomenclaturalCodeIRI` as per the Phyx.js paper: https://doi.org/10.7717/peerj.12618/table-1
This PR restores Fisher et al, 2007 from previous versions of Klados so that we can have examples of phyloreferences with specimens so we can make sure that Klados supports them. Closes #232.
It also includes some minor fixes that were discovered in creating this example file:
defaultNomenclaturalCodeURI
field from the Phyx file, but the specification says this field should be calleddefaultNomenclaturalCodeIRI
. Fixed.The backend is down (I'm working on fixing it), but I have confirmed that this works locally on my computer: