-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the Specifier component #333
Open
gaurav
wants to merge
21
commits into
master
Choose a base branch
from
simplify-specifier
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also took out an unnecessary TODO.
We have a separate box for that now.
gaurav
changed the base branch from
master
to
fix-references-to-defaultNomenclaturalCodeURI
September 23, 2024 00:25
Base automatically changed from
fix-references-to-defaultNomenclaturalCodeURI
to
master
September 23, 2024 18:35
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Specifier component has some complex logic that allows users to modify the properties of a specifier in multiple ways, but this can lead to the specifier being overwritten just be opening it (#263). This PR sets about restructuring this component so that you can no longer modify the specifier just by opening it -- you have to explicitly modify something to trigger a modification action. (This is the minimum we need to close #263).
Now, we can't just remove all of this code, because the way in which Vue Store's data model works, we can't just plug the UI directly into the data object -- we have to call
$store.commit('setSpecifierProps', {specifier, props})
or$store.commit('replaceTUnitForPhylogenyNode', {...})
to commit the results. So instead we need a model like this:loadSpecifier()
.updateSpecifier()
.Additionally, this PR:
Apomorphy
as an option for the specifier dropdown (closes Remove "Apomorphy" from specifier type as we've now implementing it elsewhere #331).Closes #320: we don't include any special support for UUIDs, but we do now note that they can be used. They appear as collection IDs.
Example taxon:
Example specimen:
Example specimen with a UUID: