Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the apomorphy description in apomorphy-based phylorefs #302

Open
gaurav opened this issue Jun 21, 2023 · 0 comments
Open

Improve the apomorphy description in apomorphy-based phylorefs #302

gaurav opened this issue Jun 21, 2023 · 0 comments

Comments

@gaurav
Copy link
Member

gaurav commented Jun 21, 2023

In PR #291, we implement apomorphy fields exactly as specified in the Phyx manuscript -- with a definition, bearingEntity and phenotypicQuality field. As per #291 (comment), it might make sense to replace that with just the free-text definition for now. If so, we would need to decided whether we want to make that change in phyx.js, or leave that functionality available but ignore it in Klados. I'm inclined to leave it as-is for Klados 1.0, and then improve it later.

In the future, we might want a "related entity" field as well. Gaurav to talk to Jim about this. Maybe a Manchester syntax field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant