Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasInternalSpecifier and hasExternalSpecifier should be removed unless they're needed #39

Open
gaurav opened this issue Jun 26, 2018 · 0 comments

Comments

@gaurav
Copy link
Member

gaurav commented Jun 26, 2018

Once upon a time, we kept the metadata for specifiers in internalSpecifiers and the OWL restrictions in hasInternalSpecifier (and ditto with external specifiers). Since specifiers are no longer OWL restrictions, we no longer need hasInternalSpecifier, and so we should get rid of it. Here's an example of it being used:

doc['hasInternalSpecifier'] = [specifier.as_jsonld() for specifier in self.internal_specifiers_list]
doc['hasExternalSpecifier'] = [specifier.as_jsonld() for specifier in self.external_specifiers_list]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant