Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for phyloreferences with multiple external specifiers #27

Open
gaurav opened this issue Apr 13, 2018 · 1 comment
Open

Add support for phyloreferences with multiple external specifiers #27

gaurav opened this issue Apr 13, 2018 · 1 comment

Comments

@gaurav
Copy link
Member

gaurav commented Apr 13, 2018

At the moment, we support phyloreferences with a single external specifier, since we can easily create a definition for a node that:

  1. has descendants for each internal specifier, and
  2. excludes lineage to one external specifier

I'm not sure if we can extend this to multiple external specifiers, since I think each "excludes lineage to" will identify a different pinning node. We should try it and, if unsuccessful, should develop a method for resolving such phyloreferences. Examples of such phyloreferences are included in Carvalho-Sobrinhoa et al, 2016, which can be used as a test case.

@hlapp
Copy link
Member

hlapp commented May 22, 2018

I'm not sure if we can extend this to multiple external specifiers, since I think each "excludes lineage to" will identify a different pinning node.

Perhaps if taken on their own. But surely the semantics here are conjunction, no? So an additional external specifier can make the identified clade smaller but never larger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants