-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken links #99
Comments
Please use https://www.npmjs.com/package/broken-link-checker to find them |
@ibennetch could you fix the links on CVEs? I can not run the tool today but will do it soon to post a complete list here |
The Weblate report is quite interesting because we're generating a link to, ch_TW and ch_CN for instance, don't immediately seem to exist on Weblate. I'll have to research this further. The -36 PMASA commits have been fixed ✅, for some reason GitHub wasn't liking the short form. The -30 ones are the short hash but seem to be working correctly as links for me. I can keep this opened to eventually change them to the long hashes, but nothing seems broken to me. |
Thank you! |
This comment was marked as resolved.
This comment was marked as resolved.
This is a full recursive report
|
|
@ibennetch some links are for versions of phpmyadmin and others are very old broken links |
🏓 @ibennetch :) |
I've fixed a few of these. A lot of them seem like false positives. LinkedIn seems to return the HTTP 999 for some reason but the links are valid. There's something odd going on with some of the Weblate links that I'm still not sure about. Some of the old links, such as the fransallen theme link, would require re-releasing an old theme and I'm not sure that's worthwhile. Several of the rest are security firms or personal websites of people who reported security issues and I can keep going through the PMASA advisories and removing those broken links. This isn't done yet — just improved. |
LinkedIn returns 999 when the machine who are trying to get the link make more than 5 (IIRC) connections in a small time window, |
Here is an update, removed linkedin and github rate limit errors
|
some links to Weblate on https://www.phpmyadmin.net/translations/
*@latin
linkscommit on https://www.phpmyadmin.net/security/PMASA-2016-36/
commit on https://www.phpmyadmin.net/security/PMASA-2016-30/
The text was updated successfully, but these errors were encountered: