Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Class Move in combination with composer "repositories" of type "path" #2727

Open
d-s-codappix opened this issue Aug 28, 2024 · 1 comment · May be fixed by phpactor/class-to-file#33
Open

Support Class Move in combination with composer "repositories" of type "path" #2727

d-s-codappix opened this issue Aug 28, 2024 · 1 comment · May be fixed by phpactor/class-to-file#33

Comments

@d-s-codappix
Copy link

d-s-codappix commented Aug 28, 2024 •
edited
Loading

Given the following setup within composer.json of a project:

    "repositories": [
        {
            "type": "path",
            "url": "local_packages/*"
        }
    ],

One can provide project specific composer packages within local_packages.
We now have packages following that structure and want to use class:move feature, which fails with:

  [RuntimeException]
  There are no class name candidates

The Phpactor\ClassFileConverter\Adapter\Composer\Psr4NameInflector will not work as it will receive /vendor/prefix/name/Classes instead of the local_packages/package/Classes path.

Adding a realpath() call within class-to-file/lib/Adapter/Composer/ComposerFileToClass seems to help. I'm not sure if that might break other things.
@dantleech
Copy link
Collaborator

Shouldn't do, feel free to make a PR ideally with a test

@d-s-codappix d-s-codappix linked a pull request Sep 4, 2024 that will close this issue
Open
d-s-codappix added a commit to d-s-codappix/fork-class-to-file that referenced this issue Sep 4, 2024
@d-s-codappix
Fix case where installed path is symlink
06b218f 
One can install packages from a local path via composers repositories
type "path".
Those are typically symlinks which were not resolved.
We therefore add a realpath() call, but falling back to old behavior if
it didn't resolve. That way we keep independent of realpath() as
requested by the inline comment.

Resolves: phpactor/phpactor#2727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix case where installed path is symlink d-s-codappix/fork-class-to-file
2 participants
@dantleech @d-s-codappix