You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm implementing a middleware pipeline third-party library using this extension with the polyfill. The implementation exhausts the Queue class of this library recursively by cloning itself. You can take a look at the implementation here.
When I run the tests with the extension, everything works perfectly well and as expected. However, when I run the tests with the polyfill, everything breaks.
Looking at the polyfill code, I realized that there was not a Ds\Queue::__clone method implemented, so when I called clone on the queue, the internal Ds\Deque containing the array was not being cloned.
I implemented the clone method in my vendor folder just for testing purposes, and this fixed it.
I can submit a PR with the fix if you are busy to fix it yourself. Just let me know.
Thanks for this awesome extension!
The text was updated successfully, but these errors were encountered:
Hi there!
I'm implementing a middleware pipeline third-party library using this extension with the polyfill. The implementation exhausts the
Queue
class of this library recursively by cloning itself. You can take a look at the implementation here.When I run the tests with the extension, everything works perfectly well and as expected. However, when I run the tests with the polyfill, everything breaks.
Looking at the polyfill code, I realized that there was not a
Ds\Queue::__clone
method implemented, so when I called clone on the queue, the internalDs\Deque
containing the array was not being cloned.I implemented the clone method in my vendor folder just for testing purposes, and this fixed it.
I can submit a PR with the fix if you are busy to fix it yourself. Just let me know.
Thanks for this awesome extension!
The text was updated successfully, but these errors were encountered: