Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testSum failures under PHP 8.3 #107

Open
NorthNick opened this issue Sep 23, 2024 · 1 comment
Open

testSum failures under PHP 8.3 #107

NorthNick opened this issue Sep 23, 2024 · 1 comment

Comments

@NorthNick
Copy link

NorthNick commented Sep 23, 2024

There are 4 testSum tests, each including the sum of ["a", true, false, null]. The implementation of Sum uses array_sum, which throws a warning when values cannot be converted to int or float under PHP 8.3 (manual page). This causes the test suite to fail, so these tests should be changed or dropped, or modified to expect a warning from PHP 8.3 onwards.

@rtheunissen
Copy link
Member

I would like to match array semantics as much as possible, so I think that means the tests should change from 8.3 onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants