Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Author in IOK #229

Open
w00dbury opened this issue Dec 2, 2023 · 5 comments
Open

FR: Author in IOK #229

w00dbury opened this issue Dec 2, 2023 · 5 comments
Assignees

Comments

@w00dbury
Copy link
Contributor

w00dbury commented Dec 2, 2023

I'm wondering if you'd consider supporting and utilizing the author field in Sigma as a way of publicly recognizing contributors in IOKs.

@IlluminatiFish
Copy link
Collaborator

I believe @bradleyjkemp already has this idea on his radar. As per #60 (comment) the author field in IOK rules will be omitted and it will be replaced by a GitHub API call to find the author of the rule instead.

@w00dbury
Copy link
Contributor Author

w00dbury commented Dec 2, 2023

I believe @bradleyjkemp already has this idea on his radar. As per #60 (comment) the author field in IOK rules will be omitted and it will be replaced by a GitHub API call to find the author of the rule instead.

Clearly my searching was insufficient. Thanks for pointing that out.

@bradleyjkemp
Copy link
Member

Having said that, the license on this repo does allow people to take these rules and use them elsewhere (which wouldn't include any future GitHub-API author stuff) so perhaps we should allow the author field?

@bradleyjkemp
Copy link
Member

Let's go for it, rule-writers can use the author field for whatever attribution they want (name, handle, etc.)

We'll figure out later the etiquette for e.g. how much tweaking of a rule is enough to add yourself to the author line :)

@IlluminatiFish
Copy link
Collaborator

Time to retrofit the existing rules :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants