Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordions do not show "-" when closed - reopened #166

Open
jcamp opened this issue Nov 4, 2022 · 3 comments
Open

Accordions do not show "-" when closed - reopened #166

jcamp opened this issue Nov 4, 2022 · 3 comments

Comments

@jcamp
Copy link

jcamp commented Nov 4, 2022

    Accordions [currently do show the "-" when open](https://github.com/philbuchanan/Accordion-Blocks/blob/master/src/block/index.scss#L77) and the "+" when closed. You can easily change the specific styling of opened vs. closed items via CSS. The intention is to keep the plugin as simple as possible and allow customization via CSS.

Originally posted by @philbuchanan in #165 (comment)

This is the current css from the wp repo:
.c-accordion__item.is-selected{border-bottom:1px solid var(--wp-admin-theme-color)!important}

@jcamp jcamp changed the title Accordions [currently do show the "-" when open](https://github.com/philbuchanan/Accordion-Blocks/blob/master/src/block/index.scss#L77) and the "+" when closed. You can easily change the specific styling of opened vs. closed items via CSS. The intention is to keep the plugin as simple as possible and allow customization via CSS. Accordions do not show "-" when closed - reopened Nov 4, 2022
@jcamp
Copy link
Author

jcamp commented Nov 4, 2022

There is a discrepancy between the WordPress repo of your plugin and your source here. The build has not worked correctly and is not using the correct css and perhaps other source? Both 1.5.0 but both look quite different?

@jcamp
Copy link
Author

jcamp commented Nov 4, 2022

https://wordpress.org/plugins/accordion-blocks/

that is not the same as you have here...?

@jcamp
Copy link
Author

jcamp commented Nov 4, 2022

The SCSS is def not anything like the dist CSS file...? (de-compiled of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant