Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search in page - use hidden=until-found #161

Open
tzeumer opened this issue Jul 9, 2022 · 0 comments · May be fixed by #162
Open

Search in page - use hidden=until-found #161

tzeumer opened this issue Jul 9, 2022 · 0 comments · May be fixed by #162

Comments

@tzeumer
Copy link

tzeumer commented Jul 9, 2022

Problem: Content in accordions can't be found by searching within the page (CTRL + F).

I just read Making collapsed content accessible with hidden=until-found at Chrome Developers where the suggested solution is to use hidden=until-found. This works in Chromium derivates as well as in a current Firefox version. The article suggests using if (!(‘onbeforematch' in document.body)) { // expand all hidden content } if an even broader browser support is aimed for.

It would be great if this would be supported by this very useful plugin.

Maybe also interesting: The article says "In addition to allowing find-in-page search on hidden regions, this feature will allow this hidden content to be accessible to search engines. Google Search will even form links that scroll to the revealed fragment.". I'm not sure this is a matter, but it seems to be true that Google results currently don't show the context if matched in a hidden accordion.
corentin-gautier pushed a commit to corentin-gautier/Accordion-Blocks that referenced this issue Jul 31, 2022
use hidden until-found - Fix philbuchanan#161
6a2cb34
@corentin-gautier corentin-gautier linked a pull request Jul 31, 2022 that will close this issue
Open
corentin-gautier pushed a commit to corentin-gautier/Accordion-Blocks that referenced this issue Jul 31, 2022
rewrite front js in vanilla - Fix philbuchanan#121
2d79bdd 
add alignment support - Fix philbuchanan#103

use hidden until-found - Fix philbuchanan#161

Remove the use of children - Maybe Fix philbuchanan#117

add resize event dispatch - Fix philbuchanan#59

revert removal of the button option
corentin-gautier pushed a commit to corentin-gautier/Accordion-Blocks that referenced this issue Jul 31, 2022
rewrite front js in vanilla - Fix philbuchanan#121
4d1f75a 
add alignment support - Fix philbuchanan#103

use hidden until-found - Fix philbuchanan#161

Remove the use of children - Maybe Fix philbuchanan#117

add resize event dispatch - Fix philbuchanan#59

revert removal of the button option

use <accordion-item> custom element
add js documentation
requestIdleCallback before window scroll

remove use of "window."
@tzeumer tzeumer mentioned this issue Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite front js in vanilla - Fix #121 corentin-gautier/Accordion-Blocks
1 participant
@tzeumer