Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple the JavaScript from the HTML structure #117

Open
philbuchanan opened this issue Mar 18, 2021 · 0 comments · May be fixed by #162
Open

Decouple the JavaScript from the HTML structure #117

philbuchanan opened this issue Mar 18, 2021 · 0 comments · May be fixed by #162
Labels
feature request New feature or request
Milestone
v2.0.0

Comments

@philbuchanan
Copy link
Owner

Currently the HTML structure is very specific and the JavaScript expects that specific structure (see use of .children(), instead of more general .find()). In some cases, other plugins wrap parts of the plugin's HTML with additional elements. This obviously breaks the accordion functionality.

A long term goal would be to decouple the JavaScript from the specific HTML structure, but this will require a much larger overhaul of both the HTML and JavaScript.

See this issue from the Support Forum for more.
@philbuchanan philbuchanan added the feature request New feature or request label Mar 18, 2021
@philbuchanan philbuchanan added this to the v2 milestone Mar 18, 2021
corentin-gautier pushed a commit to corentin-gautier/Accordion-Blocks that referenced this issue Jul 31, 2022
Remove the use of children - Maybe Fix philbuchanan#117
38caba4
@corentin-gautier corentin-gautier linked a pull request Jul 31, 2022 that will close this issue
Open
corentin-gautier pushed a commit to corentin-gautier/Accordion-Blocks that referenced this issue Jul 31, 2022
rewrite front js in vanilla - Fix philbuchanan#121
2d79bdd 
add alignment support - Fix philbuchanan#103

use hidden until-found - Fix philbuchanan#161

Remove the use of children - Maybe Fix philbuchanan#117

add resize event dispatch - Fix philbuchanan#59

revert removal of the button option
corentin-gautier pushed a commit to corentin-gautier/Accordion-Blocks that referenced this issue Jul 31, 2022
rewrite front js in vanilla - Fix philbuchanan#121
4d1f75a 
add alignment support - Fix philbuchanan#103

use hidden until-found - Fix philbuchanan#161

Remove the use of children - Maybe Fix philbuchanan#117

add resize event dispatch - Fix philbuchanan#59

revert removal of the button option

use <accordion-item> custom element
add js documentation
requestIdleCallback before window scroll

remove use of "window."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Rewrite front js in vanilla - Fix #121 corentin-gautier/Accordion-Blocks
1 participant
@philbuchanan