Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection of Wide Width and Full Width #103

Open
slambert opened this issue Dec 28, 2020 · 2 comments · May be fixed by #162
Open

Add selection of Wide Width and Full Width #103

slambert opened this issue Dec 28, 2020 · 2 comments · May be fixed by #162
Labels
feature request New feature or request

Comments

@slambert
Copy link

Accordion items are set to standard width. It would be nice to be able to set the size to wide width.

🙇

@philbuchanan philbuchanan added the feature request New feature or request label Jan 4, 2021
@philbuchanan
Copy link
Owner

@slambert I can add support for toggling alignwide and alignfull. However, styles will need to be added to themes to support these variants. For example, without specific styles, accordions with alignfull will have no gutter between the window width and the accordion content. For example (using the Twenty Twnety-One theme):

Screen Shot 2021-01-05 at 9 45 44 AM

"Accordion Item Two" has alignfull on it.

I could add padding as part of the plugin styles, however those may not line up with a theme's specific gutters, resulting in misaligned accordion items on mobile devices. For example:

Screen Shot 2021-01-05 at 9 56 23 AM

Accordion items have alignfull. Note how they don't align with the other content.

I'll think about this some more, and see if I can come up with a solution. But for now, a workaround is for you to add alignwide or alignfull as a custom class to the accordion item manually. Then you can add specific styles to your theme to accommodate.

@slambert
Copy link
Author

Hi!

However, styles will need to be added to themes to support these variants.

That makes sense.

For example, without specific styles, accordions with alignfull will have no gutter between the window width and the accordion content.

Yeah, this is how alignfull works with images and other blocks so I it shouldn't be a huge surprise.

But for now, a workaround is for you to add alignwide or alignfull as a custom class to the accordion item manually. Then you can add specific styles to your theme to accommodate.

Right! 🤦

corentin-gautier pushed a commit to corentin-gautier/Accordion-Blocks that referenced this issue Jul 31, 2022
@corentin-gautier corentin-gautier linked a pull request Jul 31, 2022 that will close this issue
corentin-gautier pushed a commit to corentin-gautier/Accordion-Blocks that referenced this issue Jul 31, 2022
add alignment support - Fix philbuchanan#103

use hidden until-found - Fix philbuchanan#161

Remove the use of children - Maybe Fix philbuchanan#117

add resize event dispatch - Fix philbuchanan#59

revert removal of the button option
corentin-gautier pushed a commit to corentin-gautier/Accordion-Blocks that referenced this issue Jul 31, 2022
add alignment support - Fix philbuchanan#103

use hidden until-found - Fix philbuchanan#161

Remove the use of children - Maybe Fix philbuchanan#117

add resize event dispatch - Fix philbuchanan#59

revert removal of the button option

use <accordion-item> custom element
add js documentation
requestIdleCallback before window scroll

remove use of "window."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants