Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Delete spinning file" because this file is still referenced #1144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bluntelk
Copy link

and required

This reverts commit 7a3b15c.

@bluntelk
Copy link
Author

This is a simple commit to revert a change that is causing grief for users using Font Awesome LESS files

@phiamo
Copy link
Owner

phiamo commented Jan 4, 2016

no sure what this is for ;-) could you explain the use case a bit ?
thanks for this contribution

@bluntelk
Copy link
Author

bluntelk commented Jan 4, 2016

Hi @phiamo

Sure. This commit is simply reverting a deleted file (spinning.css).

This file is still referenced by
https://github.com/phiamo/MopaBootstrapBundle/blob/master/Resources/public/less/font-awesome4/font-awesome.less

For LESS users, this is causing the assets to fail when dumping. We then get broken CSS and no styling.

@bluntelk
Copy link
Author

bluntelk commented Jan 7, 2016

Hi @phiamo

Any chance of having this PR merged?

@phiamo
Copy link
Owner

phiamo commented Feb 3, 2017

@isometriks do you see chances this could break anything ?

@isometriks
Copy link
Collaborator

Nope, should be fine. Although I plan on removing any embedded libraries in this repo, so I would suggest against anybody using it this way anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants