Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon font uses an incorrect "appendUniconde" option #56

Open
recrit opened this issue Jul 15, 2021 · 1 comment
Open

Icon font uses an incorrect "appendUniconde" option #56

recrit opened this issue Jul 15, 2021 · 1 comment

Comments

@recrit
Copy link

recrit commented Jul 15, 2021

Issue
The "appendUniconde" is spelled wrong and should have been "appendUnicode", so it was never being used anyways.
The new option for "gulp-svgicons2svgfont" is "prependUnicode", see changes in nfroidure/gulp-svgicons2svgfont#33.

See https://github.com/nfroidure/gulp-svgicons2svgfont
"
options.prependUnicode
Type: Boolean Default value: false

Allow to prepend unicode codepoints to icon file names in order to always keep the same codepoints accross each run
"

This leads to inconsistent codepoints on subsequent builds which leads to incorrect icons displayed for browsers thats really like to cache icon files even with a cache bust query string.

Affected Versions
All versions.

@recrit
Copy link
Author

recrit commented Jul 16, 2021

The PR #57 is for the 9.x version but this needs fixed in all versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant