Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for suppressing the sourceMappingURL #21

Open
mike-potter opened this issue Oct 20, 2016 · 0 comments
Open

Option for suppressing the sourceMappingURL #21

mike-potter opened this issue Oct 20, 2016 · 0 comments

Comments

@mike-potter
Copy link
Member

When compiling the theme for Open Atrium, we do not add the *.js.map file to the distribution to reduce the complexity of patch submissions. However, even when sourceMapEmbed is false, it still appends the sourceMappingURL to the end of the *.min.js file:

//# sourceMappingURL=oa_basetheme.script.min.js.map

Because this *.js.map file is not included in the distro, people get errors when they try to inspect the javascript since the file cannot be found.

Would be nice to add a new option for config.xml that could prevent any embedding of source map info. So, in js.js, changing:

    .pipe(sourcemaps.write((config.js.sourceMapEmbed) ? null : './'))

to something like:

    .pipe(gulpif(config.js.sourceMap || config.js.sourceMapEmbed, sourcemaps.write((config.js.sourceMapEmbed) ? null : './')))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant