Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dumb-init now included in parent image #3

Open
grayside opened this issue Feb 19, 2018 · 1 comment
Open

dumb-init now included in parent image #3

grayside opened this issue Feb 19, 2018 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@grayside
Copy link
Contributor

grayside commented Feb 19, 2018 •
edited
Loading

Problem

Now that dumb-init is added to the image in our parent, it is redundant to add it ourselves. Remove those lines.

Testing

Make sure pa11y still runs as expected after building the image locally with ./build.sh
@grayside grayside added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 14, 2018
@tjheffner
Copy link
Contributor

those lines are removed here: #7

have verified pa11y/pa11y-ci run as expected after rebuilding the image locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grayside @tjheffner