Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New branch dialog: Pressing enter should activate the ok action #1867

Closed
jecisc opened this issue Nov 27, 2024 · 1 comment · Fixed by #1869
Closed

New branch dialog: Pressing enter should activate the ok action #1867

jecisc opened this issue Nov 27, 2024 · 1 comment · Fixed by #1869
Assignees
Labels

Comments

@jecisc
Copy link
Contributor

jecisc commented Nov 27, 2024

When creating a new branch I often use the view to create a new branch by name and each time I end up wanting to press enter to validate but it does not validate the dialog. I think it should be done to improve the UX.

@AlexisCnockaert I'm not sure what is the best solution for this but maybe you can ask to Esteban?

image

@AlexisCnockaert
Copy link
Collaborator

@estebanlm I was thinking to use the whenSubmitDo: method because other presenters already use this to trigger the ok action when pressing enter, what do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants