Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IceTip* MUST NOT refer to UIManager #1761

Open
Ducasse opened this issue Nov 19, 2023 · 3 comments
Open

IceTip* MUST NOT refer to UIManager #1761

Ducasse opened this issue Nov 19, 2023 · 3 comments

Comments

@Ducasse
Copy link
Collaborator

Ducasse commented Nov 19, 2023

But request the application for a dialog eg.

diff

	^ diffModel ifNil: [ 
		  | diff |
		  UIManager default
			  informUser: 'Calculating diff'
			  during: [ diff := self calculateDiff ].
		  diffModel := IceTipCommitDiffModel
			               repositoryModel: self repositoryModel
			               on: diff ]

=>

diff

	^ diffModel ifNil: [ 
		  | diff |
		  self application 
			  informUser: 'Calculating diff'
			  during: [ diff := self calculateDiff ].
		  diffModel := IceTipCommitDiffModel
			               repositoryModel: self repositoryModel
			               on: diff ]
@Ducasse
Copy link
Collaborator Author

Ducasse commented Nov 19, 2023

waiting for a PR to be integrated in Spec.

@Ducasse
Copy link
Collaborator Author

Ducasse commented Nov 23, 2023

I started to work on this.

@Ducasse
Copy link
Collaborator Author

Ducasse commented Nov 23, 2023

#1769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant