Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of categories #25

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Oct 13, 2023

With the PR we are getting rid of categories in Hermes and are basing everything on packages and tags.

This introduces the v3 of the export format.

In some places I had to introduce different code for P10 and P12 but once P12 will be the minimal Pharo supported for this project we will be able to remove all of this.

I also used the class builder to build the traits.

If this change is approved, would it be possible to create a new release to use in the Pharo bootstrap please?
Thanks

Fixes #23

@jecisc
Copy link
Member Author

jecisc commented Oct 16, 2023

There are two problems:

  • First this version fails in Pharo 12 bootstrap while loading the TraitV2 package
  • Second, now a test is failing in Pharo 12 but it was passing before so it might be related to a recent change in Pharo 12. The sad thing is that it is passing locally :( So it's hard to debug

@jecisc
Copy link
Member Author

jecisc commented Oct 16, 2023

I found the origin of the test failure and it is from Pharo and not Hermes: pharo-project/pharo#15018

Now I'll check the second problem

@jecisc
Copy link
Member Author

jecisc commented Oct 16, 2023

Both problems are now fix!

@tesonep tesonep merged commit 5fb90ed into pharo-project:master Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#buildTrait: uses old class creation API
2 participants