Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dictionary construction for commands? #61

Open
tinchodias opened this issue Aug 10, 2019 · 0 comments
Open

Unify dictionary construction for commands? #61

tinchodias opened this issue Aug 10, 2019 · 0 comments
Labels

Comments

@tinchodias
Copy link
Contributor

These are some ways the dictionaries that will be transformed into json are created:

	self command: (OrderedDictionary new at: #ismaster put: 1; yourself).

	command := OrderedIdentityDictionary new
		at: #create put: aString;
		yourself.

	dict := {
		'insert'->collectionName.
		'documents'->{newDictionary}.
		} as: OrderedDictionary.

I see it's justified to use an ordered dictionary for commands: e.g., it's wrong to execute the command with a json that has 'document' before 'insert'. But I don't see a reason to use the Identity one.

I create this issue because of a small discussion in issue #60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant