Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pfsense_openvpn_client] Add support for additional values in digest field #134

Open
samuel-emrys opened this issue Jun 9, 2024 · 0 comments

Comments

@samuel-emrys
Copy link

samuel-emrys commented Jun 9, 2024

Is your feature request related to a problem? Please describe.
The only values that can currently be passed to the digest field are SHA1 and SHA256, as per plugins/module_utils/openvpn_client.py:41:

    digest=dict(default='SHA256', required=False, choices=['SHA256', 'SHA1']),

This populates the digest xml field:

<digest>SHA256</digest>

However, pfSense also supports substantially more than these two values, including SHA224, SHA512, SHA384, MD5, among others.

Describe the solution you'd like
Entries for each of the different options in the options list

Describe alternatives you've considered
N/A

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant