Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check code integrity #1

Open
pfaion opened this issue Dec 9, 2016 · 2 comments
Open

Check code integrity #1

pfaion opened this issue Dec 9, 2016 · 2 comments
Assignees
@pfaion
Labels
enhancement

Comments

@pfaion
Copy link
Owner

pfaion commented Dec 9, 2016

  • Make sure that all code makes sense and none is superfluous.
  • Make sure names are meaningful.
  • Do not add new features, only get the old ones right.
  • Profit.
@pfaion pfaion added this to the First publishable version milestone Dec 9, 2016
@pfaion pfaion self-assigned this Dec 9, 2016
@pfaion pfaion removed this from the First publishable version milestone Dec 9, 2016
@pfaion
Copy link
Owner Author

pfaion commented Dec 15, 2016

Renaming "compile" to "render" already makes much more sense. See d07cda6

pfaion added a commit that referenced this issue Dec 15, 2016
@pfaion
Test PyCharms GitHub Issue Tracking integration
25670b2 
see #1
pfaion added a commit that referenced this issue Jan 6, 2017
@pfaion
Adjusts some minor code-structural issues and adds some comments.
521beda 
see #1 and #2

- put UI initialization in extra method
- add comments for ui-initialization
- rename "mouseFun" to "handleCanvasClick"
- add hyphen to "pre-render" in all cases that do not correspond to variable/function names
pfaion added a commit that referenced this issue Feb 20, 2017
@pfaion
Make quotes consistent.
fa7692c 
see #1

- all quotes are now single quotes
pfaion added a commit that referenced this issue Feb 20, 2017
@pfaion
Add docstrings and fix some minor issues.
b37ad3a 
see #1 and #2

- docstring are added to all functions and the animator class
- fixed minor whitespace issue
- rename setup_handle to setup_cb
pfaion added a commit that referenced this issue Feb 20, 2017
@pfaion
Add docstrings and fix some minor issues.
2c4d638 
see #1
this closes #2

- docstring are added to all functions and the animator class
- fixed minor whitespace issue
- rename setup_handle to setup_cb
@pfaion
Copy link
Owner Author

pfaion commented Feb 20, 2017

Todo: rename "label" in QStackedLayout somehow to represent pre-rendered images.

ahoereth pushed a commit to ahoereth/MPLAnimator that referenced this issue Sep 10, 2017
@pfaion @ahoereth
Add docstrings and fix some minor issues.
55fa8de 
see pfaion#1
this closes pfaion#2

- docstring are added to all functions and the animator class
- fixed minor whitespace issue
- rename setup_handle to setup_cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfaion pfaion

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pfaion