From bb666997a3e966e60a624317f35a1564bedee11c Mon Sep 17 00:00:00 2001 From: Peter Alfonsi Date: Fri, 30 Aug 2024 11:36:05 -0700 Subject: [PATCH] Attempt to fix broken ITs Signed-off-by: Peter Alfonsi --- .../opensearch/indices/IndicesRequestCacheIT.java | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/server/src/internalClusterTest/java/org/opensearch/indices/IndicesRequestCacheIT.java b/server/src/internalClusterTest/java/org/opensearch/indices/IndicesRequestCacheIT.java index 3e002f80ee24d..505c306c1006c 100644 --- a/server/src/internalClusterTest/java/org/opensearch/indices/IndicesRequestCacheIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/indices/IndicesRequestCacheIT.java @@ -81,18 +81,14 @@ public static Collection parameters() { new Object[] { Settings.builder().put(CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING.getKey(), true).build() } ); } - /* - new Object[] { Settings.builder().put(FeatureFlags.PLUGGABLE_CACHE, "true").build() }, - new Object[] { Settings.builder().put(FeatureFlags.PLUGGABLE_CACHE, "false").build() } - */ @Override protected Settings featureFlagSettings() { - return Settings.builder() - .put(super.featureFlagSettings()).put(FeatureFlags.CONCURRENT_SEGMENT_SEARCH, "true") - .put(super.featureFlagSettings()).put(FeatureFlags.PLUGGABLE_CACHE, "true") + return Settings.builder().put(super.featureFlagSettings()) + .put(FeatureFlags.CONCURRENT_SEGMENT_SEARCH, "true") + .put(FeatureFlags.PLUGGABLE_CACHE, "true") .build(); - } + } // For now hardcode TC feature flag as true. Attempt to backport the changes allowing us to parameterize it // One of the primary purposes of the query cache is to cache aggs results public void testCacheAggs() throws Exception {