Extend sort to all Group-Object

Saving future headaches
pester · Oct 31, 2024 · 6286afa · 6286afa
1 parent 3ed8bf6
commit 6286afa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/functions/Coverage.ps1 b/src/functions/Coverage.ps1
@@ -249,7 +249,7 @@ function Get-CoverageBreakpoints {
         [ScriptBlock]$Logger
     )
 
-    # PowerShell 6.1+ sorts during Group-Object. Sorting to get equal report order for Windows PowerShell and PowerShell
+    # PowerShell 6.1+ sorts by default in Group-Object. We need to sort for consistent output in Windows PowerShell
     $fileGroups = @($CoverageInfo | & $SafeCommands['Group-Object'] -Property Path | & $SafeCommands['Sort-Object'] -Property Name)
     foreach ($fileGroup in $fileGroups) {
         if ($null -ne $Logger) {
@@ -827,9 +827,10 @@ function Get-JaCoCoReportXml {
     [long] $endTime = [System.DateTimeOffset]::UtcNow.ToUnixTimeMilliseconds()
     [long] $startTime = [math]::Floor($endTime - $TotalMilliseconds)
 
+    # PowerShell 6.1+ sorts by default in Group-Object. We need to sort for consistent output in Windows PowerShell
     $folderGroups = $CommandCoverage | & $SafeCommands["Group-Object"] -Property {
         & $SafeCommands["Split-Path"] $_.File -Parent
-    }
+    } | & $SafeCommands["Sort-Object"] -Property Name
 
     $packageList = [System.Collections.Generic.List[psobject]]@()
 

diff --git a/src/functions/TestResults.NUnit25.ps1 b/src/functions/TestResults.NUnit25.ps1
@@ -110,6 +110,7 @@ function Write-NUnitTestSuiteElements {
 
     $suites = @(
         # Tests only have GroupId if parameterized. All other tests are put in group with '' value
+        # PowerShell 6.1+ sorts by default in Group-Object. We need to sort for consistent output in Windows PowerShell
         $Node.Tests | & $SafeCommands['Group-Object'] -Property GroupId
     )
 

diff --git a/src/functions/TestResults.NUnit3.ps1 b/src/functions/TestResults.NUnit3.ps1
@@ -135,6 +135,7 @@ function Write-NUnit3TestSuiteElement {
 
     $blockGroups = @(
         # Blocks only have GroupId if parameterized (using -ForEach). All other blocks are put in group with '' value
+        # PowerShell 6.1+ sorts by default in Group-Object. We need to sort for consistent output in Windows PowerShell
         $Node.Blocks | & $SafeCommands['Group-Object'] -Property GroupId
     )