Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access request to feeGrowthOutside specs notion page #12

Open
junomonster opened this issue Aug 5, 2022 · 0 comments
Open

Access request to feeGrowthOutside specs notion page #12

junomonster opened this issue Aug 5, 2022 · 0 comments

Comments

@junomonster
Copy link

/// @return all values returned can underflow per feeGrowthOutside specs;
/// see https://www.notion.so/32990980ba8b43859f6d2541722a739b
function getAllFundingGrowth(
mapping(int24 => GrowthInfo) storage self,
int24 lowerTick,
int24 upperTick,
int24 currentTick,
int256 twPremiumGrowthGlobalX96,
int256 twPremiumDivBySqrtPriceGrowthGlobalX96
) internal view returns (FundingGrowthRangeInfo memory) {

We're currently doing some uniswap v3/trident stuffs, accidentally we found some articles about the uniswap's underflow issue.

According to this (Uniswap/v3-periphery#164), I assume that this is why perpetual team does not use safemath on the fee growth calculation logic.

However, I cannot understand that how the under/overflow situation occurs. To resolve this, I wanna get an access to that notion page.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant