Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct constant to read 64bit registry #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tonycoz
Copy link
Contributor

@tonycoz tonycoz commented Aug 7, 2023

#37 with the preprocessor definitions moved as requested.

Fixes #36

I'm seeing this issue in 32-bit builds of perl itself.

tonycoz added a commit to tonycoz/perl5 that referenced this pull request Jul 11, 2024
perl-libwin32/win32#37 was submitted ih June
2022, and fixes a bug that causes tests to fail for Win32.pm for
32-bit builds on windows, including in perl (and in 5.40.)

Jan requested a minor change to that PR which wasn't followed up on, so
I submitted perl-libwin32/win32#39 which
includes that requested change in Augest 2023.

This still has been acted on.

So import this change into blead.
tonycoz added a commit to tonycoz/perl5 that referenced this pull request Jul 11, 2024
perl-libwin32/win32#37 was submitted ih June
2022, and fixes a bug that causes tests to fail for Win32.pm for
32-bit builds on windows, including in perl (and in 5.40.)

Jan requested a minor change to that PR which wasn't followed up on, so
I submitted perl-libwin32/win32#39 which
includes that requested change in August 2023.

This still hasn't been acted on.

So import this change into blead.
tonycoz added a commit to tonycoz/perl5 that referenced this pull request Jul 11, 2024
perl-libwin32/win32#37 was submitted in June
2022, it fixes a bug that causes tests to fail for Win32.pm for
32-bit builds on windows, including in perl (and in 5.40.)

Jan requested a minor change to that PR which wasn't followed up on, so
I submitted perl-libwin32/win32#39 which
includes that requested change in August 2023.

This still hasn't been acted on.

So import this change into blead.
@jkeenan
Copy link

jkeenan commented Jul 11, 2024

@xenu, @jandubois, can you take a look at this pull request? Thanks.

tonycoz added a commit to Perl/perl5 that referenced this pull request Jul 17, 2024
perl-libwin32/win32#37 was submitted in June
2022, it fixes a bug that causes tests to fail for Win32.pm for
32-bit builds on windows, including in perl (and in 5.40.)

Jan requested a minor change to that PR which wasn't followed up on, so
I submitted perl-libwin32/win32#39 which
includes that requested change in August 2023.

This still hasn't been acted on.

So import this change into blead.
@jandubois
Copy link
Member

@jkeenan Thanks for the ping, will try to take a look later this week

@jandubois jandubois self-requested a review July 17, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Win32::IsDeveloperModeEnabled() doesn't work in 32bit Perl
4 participants