Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental multi-use and collision of 'id' in rickshaw-run.iterations[].params[].id #564

Open
atheurer opened this issue Oct 31, 2024 · 1 comment
Assignees

Comments

@atheurer
Copy link
Contributor

This ID was originally used to match a client-server ID, aka cs_id, when specific client or servers had specific benchmark params (multibench). However, this id field appears to also be used for opensearch document IDs. This becomes a problem when a run is re-post-processed. The logic in rickshaw-post-process-bench tries to match the current client it is working on to the ID found in the params, and it cannot because the ID now looks something like "DDA62AE4-9603-11EF-8F66-A769D26D3263". When this happens, all of the benchmark params are omitted when re-post-processing, which can result in an error and not generating any post-processed data for indexing.

@atheurer
Copy link
Contributor Author

There's probably a couple ways to handle this, either focus on changing what field the params use (from id to something like cs_id) or changing what field name the rickshaw-run uses. I am inclined to change the field rickshaw uses because I don't want to make a visible change to the schema of params and have to get all users to adjust to it. Most likely 'id' will become 'doc_id' in rickshaw-run.json

@k-rister k-rister moved this from Queued to In Progress in Crucible Tracking Oct 31, 2024
@k-rister k-rister self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants