Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-11148 Service management - Add/Edit service #599

Merged
merged 56 commits into from
Aug 28, 2023

Conversation

matejkubinec
Copy link
Collaborator

@matejkubinec matejkubinec commented Jan 20, 2023

What this PR does / why we need it:

Adds ability to edit standard and custom labels. Visual refresh for add service form and inventory table.

Which issue(s) this PR fixes:

PMM-11148

Screenshots:

image

image

image

FB: Percona-Lab/pmm-submodules#3026

@matejkubinec matejkubinec changed the title WIP: PMM-11148 Service management PMM-11148 Service management - Add/Edit service Jan 26, 2023
@matejkubinec matejkubinec marked this pull request as ready for review January 26, 2023 08:34
Copy link

@fabio-silva fabio-silva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small questions, but looking good!

fabio-silva
fabio-silva previously approved these changes Jan 27, 2023
@matejkubinec matejkubinec requested a review from fabio-silva June 23, 2023 11:05
fabio-silva
fabio-silva previously approved these changes Jun 26, 2023
@matejkubinec matejkubinec requested a review from fabio-silva July 19, 2023 10:12
fabio-silva
fabio-silva previously approved these changes Jul 24, 2023
fabio-silva
fabio-silva previously approved these changes Aug 16, 2023
@matejkubinec matejkubinec merged commit 3737244 into main Aug 28, 2023
@matejkubinec matejkubinec deleted the PMM-11148-inventory-manage-labels branch August 28, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants