Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project history #139

Merged
merged 13 commits into from
Jul 8, 2024
Merged

Project history #139

merged 13 commits into from
Jul 8, 2024

Conversation

khoroshevskyi
Copy link
Member

@khoroshevskyi khoroshevskyi commented Jul 3, 2024 •
edited
Loading

Changes:

  • Added functionality that saves project history after save button was clicked

TODO:

  • Add tests
  • Disable history for huge projects

@khoroshevskyi khoroshevskyi requested a review from nleroy917 July 5, 2024 14:54
nleroy917
nleroy917 previously approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks great. Just small things. The only real one is my suggestion for deleting a row before inserting history after warning that they've hit their maximum

pepdbagent/db_utils.py Show resolved Hide resolved
pepdbagent/modules/project.py Show resolved Hide resolved
pepdbagent/modules/project.py Show resolved Hide resolved
pepdbagent/modules/project.py Outdated Show resolved Hide resolved
@khoroshevskyi khoroshevskyi merged commit d2bacb6 into dev Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nleroy917 nleroy917 nleroy917 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khoroshevskyi @nleroy917