-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.7.0 #114
Release v0.7.0 #114
Conversation
# Conflicts: # requirements/requirements-all.txt # tests/conftest.py # tests/test_pepagent.py
Added pop column
# Conflicts: # pepdbagent/_version.py
Additional tests
104 favorites
Added sample module
# Conflicts: # pepdbagent/db_utils.py
Added views module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a lot of code, but at a cursory glance, it seems ok
with Session(self._sa_engine) as sa_session: | ||
project = sa_session.scalar(project_statement) | ||
if not project: | ||
raise ProjectNotFoundError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we looking for existing projects if this is the create()
function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are creating view, not project
What was changed here?
Changes:
pop
to project table and annotation model #107forked_from
feature #73