Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #107 #108 #109

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Fixed #107 #108 #109

merged 4 commits into from
Dec 18, 2023

Conversation

khoroshevskyi
Copy link
Member

  1. Added get annotation by providing list of registry paths
  2. Added pep_type sort function to annotations (pep/pop)

@khoroshevskyi
Fixed #107
de932f3 
Fixed #108
@khoroshevskyi khoroshevskyi changed the title Fixed #107, #108 Fixed #107 #108 Dec 16, 2023
@khoroshevskyi khoroshevskyi mentioned this pull request Dec 17, 2023
Merged
1 task
nleroy917
nleroy917 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this looks good, some things I made a comment on about masking errors, otherwise 👍🏼

pepdbagent/modules/annotation.py Show resolved Hide resolved
pepdbagent/modules/annotation.py Show resolved Hide resolved
pepdbagent/modules/annotation.py Show resolved Hide resolved
@khoroshevskyi khoroshevskyi merged commit 9fe02b4 into dev Dec 18, 2023
3 checks passed
@khoroshevskyi khoroshevskyi deleted the annotation_improvments branch January 9, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nleroy917 nleroy917 nleroy917 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khoroshevskyi @nleroy917