Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of processing of PEP #10

Open
nsheff opened this issue Jul 8, 2022 · 2 comments
Open

Order of processing of PEP #10

nsheff opened this issue Jul 8, 2022 · 2 comments

Comments

@nsheff
Copy link
Contributor

nsheff commented Jul 8, 2022

When a PEP is put in the database, when is it processed? I can see two possibilities:

  1. A PEP is loaded, processed, and the processed PEP is put into the database.
  2. A PEP is loaded but not processed, the unprocessed PEP is put into the database.

The advantage of 1 is that the processing only happens once, so it reduces compute time. With 2, you'd have to reprocess it every time the PEP is requested.

However, if we want to allow the user to tweak the rendering of the PEP, for example, by changing env vars (pepkit/pephub#3), this will only be possible with option 2.

Hybrid?

Is it possible to split the idea of "processing" into two stages: 1. the sample_modifiers and project_modifiers are done before entry into the database, and then 2. path expansion is done on-the-fly ?

@khoroshevskyi
Copy link
Member

At this moment, pep_db is storing all variables from peppy object. Every modification that had been done in peppy before loading to db will be saved to db. We can always reupload every project to db if it's necessury.
If I am not mistaken, pepagend and pep_db are working as your first scenario.
Correct me please if I am wrong.

@khoroshevskyi
Copy link
Member

khoroshevskyi commented Jan 19, 2023

This is outdated issue. We found solution for it.
pepdbagent receive peppy. Project object and retrieves unprocessed PEP files that are stored in Python data objects. The dictionary of unprocessed PEP is later added to the database.

@khoroshevskyi khoroshevskyi reopened this Jan 19, 2023
@nsheff nsheff added this to PEP Jun 25, 2024
@nsheff nsheff added this to the v0.9.0 milestone Jun 25, 2024
@khoroshevskyi khoroshevskyi removed this from the v0.9.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants